-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2nd try: Complete overhaul of this project to make it compatible to Angular 4 #5
base: master
Are you sure you want to change the base?
Conversation
* commit '22813a5a66ec36caca253670014331c89f5cc383': Revert "Complete overhaul of this project to make it compatible to Angular 4.…" Complete overhaul of this project to make it compatible to Angular 4.2.x. Example is a project generated with ```ng new``` and enhanced using the agular2-click-to-edit components. Library compiles using new tsconfig.json. Works fine for me. Please let me know if you are going to make a new npm release otherwise I'll do it under a new name.
sure i will test it and update npm package accordingly, will give you an update soon 👍 |
I'm reading through that here: https://medium.com/@cyrilletuzi/how-to-build-and-publish-an-angular-module-7ad19c0b4464 to make an angular model out of it. Will let you know how it goes. |
Awesome 👍 👍 |
Hi Thorsten, unfortunatly i didnt have much time to test it during the week, |
not with npm but I extracted an Angular module out of it that is easy to import/copy into an application. npm seems to be a bit more complicated |
i saw how you made the module, awesome! i cant seem to get it to work though, i get import errors.. |
Did you look at my latest commit on my fork? That works on my machine
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Nadav Shemesh <[email protected]>
Sent: Saturday, September 2, 2017 5:56:26 PM
To: nadavshemesh/angular2-click-to-edit
Cc: Thorsten Bux; Author
Subject: Re: [nadavshemesh/angular2-click-to-edit] 2nd try: Complete overhaul of this project to make it compatible to Angular 4 (#5)
i saw how you made the module, awesome! i cant seem to get it to work though, i get import errors..
trying to make it work and afterwards will make it NPM package and merge the code in github also.. might use the opportunity to add features later ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#5 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AP_uvAH-_lDSbb5rtjopIcxEqRa5sfRCks5seSZKgaJpZM4PBEmW>.
|
So far it works when copying the .ts files from the src directory over to the project you would like to use it in.
Next would be to create an npm-package out of the src files.
Can you do that?
The build takes the src .ts files and compiles them into ./lib/
I just don't know how to make that now into a npm package.