Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd try: Complete overhaul of this project to make it compatible to Angular 4 #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ThorstenBux
Copy link
Contributor

So far it works when copying the .ts files from the src directory over to the project you would like to use it in.
Next would be to create an npm-package out of the src files.
Can you do that?

The build takes the src .ts files and compiles them into ./lib/
I just don't know how to make that now into a npm package.

Thorsten Bux added 3 commits August 24, 2017 20:19
* commit '22813a5a66ec36caca253670014331c89f5cc383':
  Revert "Complete overhaul of this project to make it compatible to Angular 4.…"
  Complete overhaul of this project to make it compatible to Angular 4.2.x. Example is a project generated with ```ng new``` and enhanced using the agular2-click-to-edit components. Library compiles using new tsconfig.json. Works fine for me. Please let me know if you are going to make a new npm release otherwise I'll do it under a new name.
@nadavshemesh
Copy link
Owner

sure i will test it and update npm package accordingly, will give you an update soon 👍

@ThorstenBux
Copy link
Contributor Author

I'm reading through that here: https://medium.com/@cyrilletuzi/how-to-build-and-publish-an-angular-module-7ad19c0b4464

to make an angular model out of it. Will let you know how it goes.

@nadavshemesh
Copy link
Owner

Awesome 👍 👍

@nadavshemesh
Copy link
Owner

Hi Thorsten, unfortunatly i didnt have much time to test it during the week,
im hoping to do to it during the weekend, any luck with npm?

@ThorstenBux
Copy link
Contributor Author

not with npm but I extracted an Angular module out of it that is easy to import/copy into an application. npm seems to be a bit more complicated

@nadavshemesh
Copy link
Owner

i saw how you made the module, awesome! i cant seem to get it to work though, i get import errors..
trying to make it work and afterwards will make it NPM package and merge the code in github also.. might use the opportunity to add features later ;)

@ThorstenBux
Copy link
Contributor Author

ThorstenBux commented Sep 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants