More build fixes #76
Open
More build fixes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed bad reference to MS Band dll's - Added missing reference to System.IO - Updated exception message as BluetoothDeviceInfo.Id is no longer available - switched to using Name
…re inaccurate Filter invalid map points before exporting to GPX. - Updated BikeEvent & RunEvent to return IEnumerable<> instead of naked List<>. - IEnumerable backed by new BandMapPointCollection which serves as central place to execute any filtering/processing etc on map points as they get exported. Just runs a simple filter on bad mappoints currently. - Added Unit
Updated to compile and work with v1.3.10423.3 of the MS Band dll's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build fixes resulting from the new MS Band dll API changes in v1.3.10423.3. Band no longer crashes on connection, themes, retrieval of tiles & activities etc all seem to work fine after changes. Would be worth someone more familiar with the UI aspects on unBand to give this double check though please.