Add call to txStandBy() in write_to_pipe
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If a write fails while auto-ack is enabled using `writeFast()` there is a need to call txStandBy() or subsequent writes will fail. It also allows extra time for the current write to succeed.
|
Well, this is a little embarrassing. I need to brush up on the context of this (seemingly simple) change. I forget how the |
2bndy5
reviewed
Jun 17, 2024
2bndy5
approved these changes
Jun 17, 2024
2bndy5
pushed a commit
that referenced
this pull request
Jun 17, 2024
- If a write fails while auto-ack is enabled using `writeFast()` there is a need to call txStandBy() or subsequent writes will fail. It also allows extra time for the current write to succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeFast()there is a need to calltxStandBy()or subsequent writes will fail. It also allows extra time for the current write to succeed. In initial testing most of the failed writes ended up being successful after callingtxStandBy(txTimeout);