-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for 64-bit OS #218
Conversation
- Change unsigned long to uint32_t in examples
Change %lu to %u
I have a PR in the org repo to update to
|
Whatever allocates a smaller footprint is preferable I think. |
It is odd (& annoying) that unchanged files passed the checks in master but are failing on this branch (RF24Network_config.h and RF24Network.cpp). I can limit the check-formatting step to only analyze changed lines... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to have to update .clang-format config file in a separate PR (on all repos). So, I'm good with this as it is.
RPi3 & RPi2: RPi OS 32-bit
RPi5: RPi OS 64-bit
So v16 is available on newer RPis, but the default install across versions is v14.0.6 it looks like. |
Ok, I'll adjust for v14. |
BTW, you can use |
Is this something we should also push to 1.x branch? |
Hmm, I forgot about the 1.x branch already. I'll do that one right before merging these changes I guess. |
We might have been using v12.0.0 before, but the CI seems to be using v12.0.1 now. I don't know if that was the actual problem though. |
- Modify examples files for 64-bit OS #218
All I did was change unsigned long to uint32_t in examples, and now the formatting check is failing lol. I'm thinking we should use the version of clang-format that ships with RPi, which is currently 14.0.6 on my RPi5.
In any case, I'm not sure whether to make the same changes in the regular Arduino and Pico examples, because I don't think there are any 64-bit Arduinos yet.
We might want to change it for continuity, so they all read the same, but that would be the only reason I think.