Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of cookies in Chromium cookie database versions >=24. #73

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Fix handling of cookies in Chromium cookie database versions >=24. #73

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
79dc09e
Fix handling of cookies in Chromium cookie database versions >=24.
chrisgavin Oct 23, 2024
c105fdb
Handle non-UTF8 sequences in encrypted cookie values.
chrisgavin Oct 23, 2024
5ee5527
Wrap some long lines.
chrisgavin Oct 23, 2024
ead2b75
Add a link to the Chromium source code explaining the version 24 format.
chrisgavin Oct 23, 2024
a01f3f5
Handle missing meta table and version in the cookie database.
chrisgavin Oct 23, 2024
34c5a28
Remove an unused variable.
chrisgavin Oct 23, 2024
4028b20
Run black.
chrisgavin Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/pycookiecheat/chrome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def clean(decrypted: bytes) -> str:


def chrome_decrypt(
encrypted_value: bytes, key: bytes, init_vector: bytes
encrypted_value: bytes, key: bytes, init_vector: bytes, cookie_database_version: int
chrisgavin marked this conversation as resolved.
Show resolved Hide resolved
) -> str:
"""Decrypt Chrome/Chromium's encrypted cookies.

Expand All @@ -88,6 +88,10 @@ def chrome_decrypt(
decryptor = cipher.decryptor()
decrypted = decryptor.update(encrypted_value) + decryptor.finalize()

if cookie_database_version >= 24:
# Cookies in database version 24 and later include a SHA256 hash of the domain to the start of the encrypted value.
chrisgavin marked this conversation as resolved.
Show resolved Hide resolved
decrypted = decrypted[32:]

return clean(decrypted)


Expand Down Expand Up @@ -310,6 +314,9 @@ def chrome_cookies(

conn.row_factory = sqlite3.Row

sql = "select value from meta where key = 'version';"
cookie_database_version = int(conn.execute(sql).fetchone()[0])

# Check whether the column name is `secure` or `is_secure`
secure_column_name = "is_secure"
for (
Expand Down Expand Up @@ -344,6 +351,7 @@ def chrome_cookies(
row["encrypted_value"],
key=enc_key,
init_vector=config["init_vector"],
cookie_database_version=cookie_database_version,
)
del row["encrypted_value"]
cookies.append(Cookie(**row))
Expand Down
Loading