Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly set the the useNativeDriver to false #264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −37
Open

explicitly set the the useNativeDriver to false #264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf78b9b
explicitly set the the useNativeDriver to false
gabrielslach May 7, 2020
ab55f94
Fixed issue with proptypes deprecations react
gabrielslach May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions changelog.md
View file
Original file line number Diff line number Diff line change
@@ -7,10 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- `bottom` key for `contentInset` prop

## [0.16.0] - 2019-10-24

### Added
2 changes: 0 additions & 2 deletions src/components/affix/index.js
View file
Original file line number Diff line number Diff line change
@@ -11,8 +11,6 @@ export default class Affix extends PureComponent {

static propTypes = {
numberOfLines: PropTypes.number,
style: Animated.Text.propTypes.style,

color: PropTypes.string.isRequired,
fontSize: PropTypes.number.isRequired,

12 changes: 6 additions & 6 deletions src/components/field-filled/__snapshots__/test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -150,9 +150,9 @@ exports[`renders 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -313,9 +313,9 @@ exports[`renders accessory 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -475,9 +475,9 @@ exports[`renders counter 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -660,9 +660,9 @@ exports[`renders disabled value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -822,9 +822,9 @@ exports[`renders title 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -1001,9 +1001,9 @@ exports[`renders value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
12 changes: 6 additions & 6 deletions src/components/field-outlined/__snapshots__/test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -270,9 +270,9 @@ exports[`renders 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -553,9 +553,9 @@ exports[`renders accessory 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -835,9 +835,9 @@ exports[`renders counter 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -1136,9 +1136,9 @@ exports[`renders disabled value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -1418,9 +1418,9 @@ exports[`renders title 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
@@ -1717,9 +1717,9 @@ exports[`renders value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 12,
"paddingRight": 12,
},
26 changes: 13 additions & 13 deletions src/components/field/__snapshots__/test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -147,9 +147,9 @@ exports[`renders 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -306,9 +306,9 @@ exports[`renders counter 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -488,9 +488,9 @@ exports[`renders default value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -647,9 +647,9 @@ exports[`renders disabled value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -806,9 +806,9 @@ exports[`renders error 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -983,9 +983,9 @@ exports[`renders left accessory 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -1148,9 +1148,9 @@ exports[`renders multiline value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -1332,9 +1332,9 @@ exports[`renders prefix 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -1491,9 +1491,9 @@ exports[`renders restriction 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -1674,9 +1674,9 @@ exports[`renders right accessory 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -1858,9 +1858,9 @@ exports[`renders suffix 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -2017,9 +2017,9 @@ exports[`renders title 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
@@ -2193,9 +2193,9 @@ exports[`renders value 1`] = `
"alignItems": "flex-start",
"flexDirection": "row",
"justifyContent": "flex-end",
"minHeight": 8,
},
Object {
"minHeight": 8,
"paddingLeft": 0,
"paddingRight": 0,
},
5 changes: 2 additions & 3 deletions src/components/field/index.js
View file
Original file line number Diff line number Diff line change
@@ -79,7 +79,6 @@ export default class TextField extends PureComponent {
input: PropTypes.number,
left: PropTypes.number,
right: PropTypes.number,
bottom: PropTypes.number,
}),

labelOffset: Label.propTypes.offset,
@@ -129,7 +128,6 @@ export default class TextField extends PureComponent {
input: 8,
left: 0,
right: 0,
bottom: 8,
};

static labelOffset = {
@@ -223,7 +221,9 @@ export default class TextField extends PureComponent {

let options = {
toValue: this.focusState(),
useNativeDriver: false,
duration,

};

startAnimation(focusAnimation, options, this.onFocusAnimationEnd);
@@ -572,7 +572,6 @@ export default class TextField extends PureComponent {
let containerStyle = {
paddingLeft: contentInset.left,
paddingRight: contentInset.right,
minHeight: contentInset.bottom,
};

let styleProps = {
1 change: 1 addition & 0 deletions src/components/field/styles.js
View file
Original file line number Diff line number Diff line change
@@ -22,6 +22,7 @@ export default StyleSheet.create({
},

helperContainer: {
minHeight: 8,
flexDirection: 'row',
justifyContent: 'flex-end',
alignItems: 'flex-start',
2 changes: 0 additions & 2 deletions src/components/helper/index.js
View file
Original file line number Diff line number Diff line change
@@ -11,8 +11,6 @@ export default class Helper extends PureComponent {

disabled: PropTypes.bool,

style: Animated.Text.propTypes.style,

baseColor: PropTypes.string,
errorColor: PropTypes.string,

1 change: 0 additions & 1 deletion src/components/label/index.js
View file
Original file line number Diff line number Diff line change
@@ -43,7 +43,6 @@ export default class Label extends PureComponent {
y1: PropTypes.number,
}),

style: Animated.Text.propTypes.style,
label: PropTypes.string,
};