Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UI and functions for initial run details page #78

Merged
merged 33 commits into from
Aug 28, 2020
Merged

Implement UI and functions for initial run details page #78

merged 33 commits into from
Aug 28, 2020

Conversation

kungpaogao
Copy link
Member

@kungpaogao kungpaogao commented Aug 21, 2020 •
edited
Loading

Summary

This pull request is the first step towards implementing the run details page.

Implemented features:

  • status slider to quickly view run status
    image
  • staff notes that can be edited on the page
    image
  • click pickups and dropoffs to view furniture details (in furniture card dialog)
  • button for updating the run status
    Screen Recording 2020-08-21 at 11 27 38
  • menu actions for archiving and exporting the run (currently disabled)

Other changes:

  • updated Furniture data model - added clientId property
  • updated Run data model - include notes property
  • created Firestore converters for Furniture and Run data models
  • updated EditCard component to include "readonly" mode
  • moved staff notes to top of EditCard (resolves Move staff notes to top of furniture edit card #75)

Test Plan

image

See preview link as well.

Breaking Changes

  • updated data models - see Furniture.ts, furniture/Timing.ts and Run.ts changes
  • fixed the dates in furniture table

Next Steps

  • run details is pretty much done in terms of UI
  • need to optimize the UI for scaling (it's set to 100% width regardless of screen size right now)
  • functions for the run menu items
  • create functions/security rules to allow run detail pages to be shared
  • see Add pages and models for scheduling and viewing runs #53 for tracking

kungpaogao added 30 commits July 29, 2020 01:21
@kungpaogao
Update run preview card to use Object.keys length
3393529
@kungpaogao
Implement card display from Figma for run details
b6f660d
@kungpaogao
Add notes field to Run data model
fb02280
@kungpaogao
Add notes to sample data in RunPreview
529debd
@kungpaogao
Use notes from actual data in RunDetail
194d3e8
@kungpaogao
Implement ability to view furniture in run details
37e5c17
@kungpaogao
Add readonly prop to edit card, dialog
3d8b152 
- disables edit toggle and menu actions
@kungpaogao
Add mutations for updating run
b470dac
@kungpaogao
Add edit button to run detail notes
8f03289
@kungpaogao
Fix warning for invalid default prop
9fe3afa
@kungpaogao
Implement Firestore converter for Furniture (#74)
a25bf30 
- change Timing properties back to Date type
- add a converter toDate() - not sure if necessary
- use converter in bind actions
- update mock data
@kungpaogao
Move cleanUndefined to converters, return copy
cd4635f
@kungpaogao
Implement state, actions for binding, updating run
1c50b34
@kungpaogao
Use new actions in RunDetail
5caf2e2
@kungpaogao
Implement commit run updates in run details
8114f39
@kungpaogao
Add status to run detail
ec19ccc
@kungpaogao
Implement Firestore converter for runs
2640c26
@kungpaogao
Use runConverter and update run data model
249727c
@kungpaogao
Create icon component for furniture classes
c28507d
@kungpaogao
Abstract run detail card sections to component
2aa6d7f
@kungpaogao
Use new components on RunDetail page
7c2c5bd
@kungpaogao
Change "type" to
da4b425 
"variant", pass as prop
@kungpaogao
[Data model] Add clientId to furniture data model
a98e3af
@kungpaogao
[Service] Update batch update to check dropoffs
2ff7cda
@kungpaogao
[Data model] Clean up Run data model
3369334
@kungpaogao
Add support for dropoffs in RunDetailSection
c3bdcca
@kungpaogao
Move staff notes to top of EditCard (#75)
b11df2a
@kungpaogao
[Breaking] [Data model] Fix dates in table
90aa535
@kungpaogao
Remove redundant function - use Object.values
086c1ba
@kungpaogao
Add support for disabled menu items
0d06ccb
@kungpaogao kungpaogao self-assigned this Aug 21, 2020
@kungpaogao kungpaogao added this to the MVP milestone Aug 21, 2020
@kungpaogao kungpaogao added design Design-related features feature New feature or request labels Aug 21, 2020
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/78/

@kungpaogao kungpaogao merged commit 8fa0304 into master Aug 28, 2020
@kungpaogao kungpaogao deleted the kungpaogao/run-details branch August 28, 2020 01:25
@kungpaogao kungpaogao mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crencricca crencricca Awaiting requested review from crencricca

@GeoffreyBrann GeoffreyBrann Awaiting requested review from GeoffreyBrann

@jweed4033 jweed4033 Awaiting requested review from jweed4033

@kira-segenchuk kira-segenchuk Awaiting requested review from kira-segenchuk

@PotatoInDespair PotatoInDespair Awaiting requested review from PotatoInDespair

@rayrayweng rayrayweng Awaiting requested review from rayrayweng

Assignees

@kungpaogao kungpaogao

Labels
design Design-related features feature New feature or request
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Move staff notes to top of furniture edit card
1 participant
@kungpaogao