Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donor and address search and filter #67

Merged
merged 20 commits into from
Jul 16, 2020
Merged

Donor and address search and filter #67

merged 20 commits into from
Jul 16, 2020

Conversation

kira-segenchuk
Copy link
Contributor

@kira-segenchuk kira-segenchuk commented Jul 16, 2020 •
edited
Loading

Summary

  • implemented donor filter (as autocomplete)
  • added zone header
  • implemented zone filter (as autocomplete)
  • implemented search so that a space acts as an AND operator and the search looks through all headers
  • changed date filter format
  • fixes Search doesn't work well with custom filters #62

Test Plan

View of new date filter format
donorfilter1
Date filter being used
donorfilter2
search being used
donorfilter3
space being used as an AND operator in search
donorfilter4
autocomplete functionality in donor filter
donorfilter5
donor filter being used
donorfilter6
zone filter being used
donorfilter7

@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/67/

@kungpaogao kungpaogao changed the title Kira/donor search feature Donor and address search and filter Jul 16, 2020
@kungpaogao kungpaogao added this to the MVP milestone Jul 16, 2020
@kungpaogao kungpaogao added design Design-related features feature New feature or request labels Jul 16, 2020
kungpaogao
kungpaogao approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@kungpaogao kungpaogao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new search 😍

@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/67/

@kira-segenchuk kira-segenchuk merged commit 6912c3b into master Jul 16, 2020
@kira-segenchuk kira-segenchuk deleted the kira/donor-search-feature branch July 16, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kungpaogao kungpaogao kungpaogao approved these changes

Assignees

@kira-segenchuk kira-segenchuk

Labels
design Design-related features feature New feature or request
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Search doesn't work well with custom filters
2 participants
@kira-segenchuk @kungpaogao