Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions for current item #64

Merged
merged 21 commits into from
Jul 3, 2020
Merged

Actions for current item #64

merged 21 commits into from
Jul 3, 2020

Conversation

kungpaogao
Copy link
Member

Summary

This pull request implements the actions in the furniture card dialog for the current item (related to #5).

Test Plan

These actions in the menu actually work :)
image

Breaking Changes

  • renamed parameter in functions - calls that use the old parameter name won't work as expected
  • renamed db.ts to firebase.ts - it exports more than just db now
  • dialog logic is moved to FurnitureCardDialog component
  • Vuex action commitUpdates no longer takes an argument
  • edit card dialog show behavior is based on computed property now

Next Steps

  • when we have runs, we should add that action to the menu as well - otherwise, we're pretty much done with the basic "CRUD" actions for the inventory/archive tables

kungpaogao added 18 commits June 16, 2020 16:14
@kungpaogao
Rename un/archive actions to un/archiveSelected
6b5bf74
@kungpaogao
Update edit card dialog behavior
6b349f2 
- show card when current is non-null
- uses computed property
@kungpaogao
Add events for export and archive from edit card
4768145
@kungpaogao
Implement module actions for archiving current
7b798fb 
- also unarchive, delete
- renamed deleteItems --> deleteSelected
@kungpaogao
Rename category to collection in XLSX function
f1fc6fc
@kungpaogao
Add exports for other Firebase services
e4f9424
@kungpaogao
Add exportItems to FirestoreService
4e592e6
@kungpaogao
Rename db to firebase
2fd18e8 
- firebase contains db, functions, storage
@kungpaogao
Implement actions for export current and selected
021b06c
@kungpaogao
Update inventory to use new export actions
6c02b01
@kungpaogao
Remove collection parameter from commitUpdates
b18852b 
- uses state.collection now
@kungpaogao
Move all dialog logic into FurnitureCardDialog
f7adaf1 
- now contains the UnsavedDialog
- handles closing, saving, toggling edit
@kungpaogao
Add dialogs back to Archive
d11628b 
- uses new furniture card dialog
@kungpaogao
Add loading to menu actions in ViewActionGroup
8b4cb88
@kungpaogao
Add menu actions and loading props for EditCard
044f5d1
@kungpaogao
Add unarchive events to EditCard
a94fb2a 
- and FurnitureCardDialog
- maybe think of way of generalizing custom events?
- e.g., emit('custom', $event)
@kungpaogao
Implement current actions for Inventory, Archive
32285b5
@kungpaogao
Update functions to use Node 10
aebf201
@kungpaogao kungpaogao added the feature New feature or request label Jun 25, 2020
@kungpaogao kungpaogao added this to the MVP milestone Jun 25, 2020
@kungpaogao kungpaogao self-assigned this Jun 25, 2020
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/64/

@kungpaogao
Fix whitespace
9765991
@kungpaogao
Fix bug that shows unsaved dialog after save
e0531a8 
- happened if you closed to quickly after an edit
- made things async/await
- added loading
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/64/

rayrayweng
rayrayweng approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@rayrayweng rayrayweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How would I be able to actually test the actions out (insufficient permissions)?

@kungpaogao kungpaogao merged commit a3170ce into master Jul 3, 2020
@kungpaogao kungpaogao deleted the kungpaogao/current-actions branch July 3, 2020 19:42
@kungpaogao kungpaogao restored the kungpaogao/current-actions branch July 7, 2020 14:57
@kungpaogao kungpaogao deleted the kungpaogao/current-actions branch July 7, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrayweng rayrayweng rayrayweng approved these changes

@PotatoInDespair PotatoInDespair Awaiting requested review from PotatoInDespair

@crencricca crencricca Awaiting requested review from crencricca

@kira-segenchuk kira-segenchuk Awaiting requested review from kira-segenchuk

@jweed4033 jweed4033 Awaiting requested review from jweed4033

Assignees

@kungpaogao kungpaogao

Labels
feature New feature or request
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Archive missing ability to view furniture details
2 participants
@kungpaogao @rayrayweng