Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Bar #60

Merged
merged 26 commits into from
Jun 25, 2020
Merged

Filter Bar #60

merged 26 commits into from
Jun 25, 2020

Conversation

kira-segenchuk
Copy link
Contributor

@kira-segenchuk kira-segenchuk commented Jun 18, 2020 •
edited by kungpaogao
Loading

Summary

  • implemented button for filters
  • implemented dropdown panel for choosing filters
  • implemented filter capacity for status, class, and date added using checkboxes and a date picker
  • implemented chips that show if filters are engaged, and can also clear respective filters
  • resolves Inventory View - filters #9

Test Plan

Updated UI
image

Opened filter dropdown
filters1

Opened filter dropdown with all filters selected
filters2

Closed filter dropdown with all filters selected, shows how filters affect table
filters3

Breaking Changes

Next Steps

  • change table to include donor name
  • add filter for donors based on typing in the name

Other Notes

  • a bunch of changes to Inventory so will likely cause merge conflicts

@kungpaogao kungpaogao added the feature New feature or request label Jun 18, 2020
@kungpaogao kungpaogao added this to the MVP milestone Jun 18, 2020
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

@kungpaogao
Filter design improvements
b7240e2 
- transition animation
- gray background
- spacing fixes
- change filter button style
@kungpaogao
Move formatDate to Timing class
76cdf50
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

@kungpaogao
Remove headers constant
cf678aa
@kungpaogao
Create new table filters component
ed0032b
@kungpaogao
Use new filter component in Inventory
52d2fe4 
- prep Archive for new component
- move table header to folder in components
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

1 similar comment
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

@kungpaogao
Fix VSCode settings
b8b658b
@kungpaogao
Add types to filter functions
07bf521
@kungpaogao
Update v-content to v-main
88d43d2 
- fix warning from new Vuetify update
@kungpaogao
Implement simple searchFilter
972e14b 
- search only works on columns in table without filter function
- for us, this is just the address
@github-actions
Copy link

Deployed to https://n2n-milstein.github.io/inventory/60/

@kungpaogao kungpaogao mentioned this pull request Jun 25, 2020
Closed
kungpaogao
kungpaogao approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@kungpaogao kungpaogao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo filters!!

@kira-segenchuk kira-segenchuk merged commit 46e22a8 into master Jun 25, 2020
@kira-segenchuk kira-segenchuk deleted the kira-filter branch June 25, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kungpaogao kungpaogao kungpaogao approved these changes

Assignees

@kira-segenchuk kira-segenchuk

Labels
feature New feature or request
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Inventory View - filters
2 participants
@kira-segenchuk @kungpaogao