Create archive page #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- is the layout from Inventory - allows for reuse in similar pages (e.g., archive)
- archive uses FurnitureTable - no data currently - editing and exporting need to be reimplemented
- made Firestore service into a class - class tied to collection - created inventory and archive variants - backwards compatible!
- clear current when setting new current instead of when closing
- allows caller to pass in collection - collection used to generate service
- allows actions to be decoupled - actions in Inventory and Archive will be different
- takes actions as a prop - EditCard stores actions and creates ViewActionGroup
- can set disabledMessage, which is displayed as tooltip - added naive loading - only works for downloading
- changed to arrow functions so that `this` is lexically bound - fixes bug where `this.collection` can't be accessed
- gets the document - deletes it from inventory - adds it to archive
- archives selected items - calls InventoryService.archiveItem - clears selected
- might add action types later
- working towards making Vuex less verbose - trying to abstract the current model to be modular and reusable
- abstracted inventory into a "collection" module - inventory, archive now separate Vuex modules - createCollectionModule() is Vuex module factory function - added back types... wups - added more types - fixed Vuex calls from Inventory and Archive
- rip - superseded by collection modules
…tem categories Update cloud function to take in extra parameter to incorporate exportation from other categories besides inventory
- create module using new moduleActions parameter
- fixed some code in inventory service to match
- fixes errors with selecting and current
- figured out how to abstract loading!! - based on reasoning with computed properties for filters earlier
kungpaogao
requested review from
rayrayweng,
PotatoInDespair,
crencricca,
kira-segenchuk,
GeoffreyBrann,
jweed4033 and
ajm462
|
Deployed to https://n2n-milstein.github.io/inventory/58/ |
Update export spreadsheet to allow for greater flexibility with what page to export from
|
Deployed to https://n2n-milstein.github.io/inventory/58/ |
|
Deployed to https://n2n-milstein.github.io/inventory/58/ |
|
Deployed to https://n2n-milstein.github.io/inventory/58/ |
|
Deployed to https://n2n-milstein.github.io/inventory/58/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements the archive page and abstracts a lot of the existing code base. The archive is basically the same as the inventory, so most of this PR is aimed at maximizing reuse of code (mainly in components, network, store).
views/Archive.vue+ routes - the new pagecomponents/FurnitureTable.vue- data table and edit card dialogcomponents/FurnitureTableHeader.vue- header and searchcomponents/ViewActionGroup.vue- creates buttons, tooltips, and menus for each view action; replacesInventoryActions.vue(improves Inventory View - actions #5)data/ViewAction.ts- new type for view actions (e.g., table actions and edit card actions)network/firestore-service.ts- extended ininventory-serviceandarchive-servicestore/collection/*- abstracted version of the previousinventorymodulecreateCollectionModule(collection: collections)factory functioninventory-serviceandarchive-service, respectivelyThis is a massive PR, and I should've broken it down more (i.e., handle Vuex abstractions in a separate PR).
Test Plan
Play around with the preview link.
Breaking Changes
Next Steps