-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usePrunedSchema
plugin
#2157
base: main
Are you sure you want to change the base?
Conversation
|
f64c46e
to
f94691d
Compare
💻 Website PreviewThe latest changes are available as preview in: https://57d381bd.envelop.pages.dev |
✅ Benchmark Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we want to do this on runtime, why not have a pruned schema at build time before the server even starts? This way the pruned schema is also part of the schema registry?
This is probably for when you are not fully in control of the schema you are exposing, like federating multiple schemas from other teams in your company :-) But If you think this is not useful I can close it. I'm not that much convinced of the utility of this, it should perhaps better be applied on schema loading. But this has the good aspect of being very simple to add to an existing setup. Just put the plugin and the schema is cleaned up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I see how it can be easy to integrate
Description
Adds a plugin to automatically clean up the schema by applying
pruneSchema
from@graphql-tools/utils
.Type of change