refactor: Make Endpoint::node_addr sync and infallible, and add Endpoint::node_addr_initialized
#3192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3192/docs/iroh/ Last updated: 2025-02-19T13:53:47Z |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
Endpoint::node_addra synchronous, infallible function that always returns the current state of the endpoint's node address. Right after binding that node address might be empty, because neither the home relay nor our direct addresses are yet determined.Therefore, we add a
async fn node_addr_initialized(&self)that waits for either the home relay or the direct addresses to be initialized.Alternative to #3190
Breaking Changes
Endpoint::node_addrnow is sync and infallible. If you want to wait for the address to be initialized, awaitEndpoint::node_addr_initializedbefore.Notes & open questions
Change checklist