Fix test, add test #3185
Merged
Fix test, add test #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3185/docs/iroh/ Last updated: 2025-02-14T13:35:33Z |
matheus23
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Interesting!
So essentially quic_endpoint_closes_fast behaves the same as before, but only because we don't make use of ICMP packets.
And quic_endpoint_unresponsive makes sure that we do have the eventually connecting behavior we're looking for, even if the connection takes more than 1s.
Sweet, I like it. I think I'll change the test names a bit, but other than that 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the test by not using a fixed port: that's asking for flakyness.
Add test ensuring that the connection still succeeds even after that
1s deadline exceeds.