feat(iroh-net-report): Support wasm32 building & running #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3139/docs/iroh/ Last updated: 2025-02-14T09:30:33Z |
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
from
2b9f228 to
942d4ac
Compare
|
The only thing that iroh-net-report would be doing in Wasm is running HTTPS probes. I have a browser version of iroh working that doesn't depend on iroh-net-report at all. This makes stuff a lot simpler. So, I'm going to close this. |
|
Hm, what I wrote above is incorrect. We do need the relay latencies to decide which relay to connect to. |
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
3 times, most recently
from
19fc5ba to
4a84051
Compare
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
from
4a84051 to
5191a9c
Compare
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
from
5286020 to
d4149ba
Compare
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
2 times, most recently
from
13b0ae0 to
3fd7585
Compare
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
from
3fd7585 to
f9a3720
Compare
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
from
f9a3720 to
059ec18
Compare
matheus23
force-pushed
the
matheus23/iroh-net-report-browser
branch
from
059ec18 to
85ea312
Compare
dignifiedquire
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes iroh-net-report compile to Wasm. We make sure it's likely to work by grepping the generated Wasm file for "env" imports (which would make it not work in browsers).
Mostly this will disable functionality in iroh-net-report for the browser target - specifically, it disables STUN, QAD, ICMP and all other probes besides HTTPS to relays.
I've experimentally verified this code works with an integration test, it's really hard to come up with a good strategy for automating this testing due to requiring running cross-languages.
I'd like to do that as a follow-up once #3145 is merged.
Change checklist