Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ruby 3 keyword args in parse! #1

Open
wants to merge 2 commits into
base: dev/ruby-3
Choose a base branch
from
Open

fix: ruby 3 keyword args in parse! #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321191a
fix: ruby 3 keyword args in parse!
mayank-gandhi-grepruby Feb 15, 2023
b309e0f
Added support for configuring page_load_strategy for selenium Chrome
mayank-gandhi-grepruby Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kimurai/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def self.parse!(handler, *args, **request)
if args.present?
spider.public_send(handler, *args)
elsif request.present?
spider.request_to(handler, request)
spider.request_to(handler, **request)
else
spider.public_send(handler)
end
Expand Down
5 changes: 5 additions & 0 deletions lib/kimurai/browser_builder/selenium_chrome_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ def build
# Create driver options
opts = { args: %w[--disable-gpu --no-sandbox --disable-translate] }

# Page load strategy :normal, :eager, :none
if page_load_strategy = @config[:page_load_strategy].presence
opts.merge!(page_load_strategy: page_load_strategy)
end

# Provide custom chrome browser path:
if chrome_path = Kimurai.configuration.selenium_chrome_path
opts.merge!(binary: chrome_path)
Expand Down
2 changes: 1 addition & 1 deletion lib/kimurai/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Kimurai
VERSION = "1.4.1"
VERSION = "1.4.3"
end