-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B1' derived ef #156
B1' derived ef #156
Conversation
To do:
|
Poke me if this is ready and I'll give it a review. Failing tests can be simply fixed by bumping the expected number of derived eigenfunctions for the unit tests and regenerating the regression answers for the Couette and Taylor-Couette cases. pytest test_taylor_couette.py --generate and then it will ask you to confirm when the tests run. You can add the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
========================================
Coverage 94.93% 94.94%
========================================
Files 161 161
Lines 9138 9155 +17
========================================
+ Hits 8675 8692 +17
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks good -- quick question, for testing purposes I assume that (at least) one of the regression tests you regenerated include a case in which Merge when ready :) |
|
PR description
Added the derivative of B1 to the derived eigenfunctions to allow for computation of Delta' for tearing modes.
New features
Legolas
Checklist