Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B1' derived ef #156

Merged
merged 4 commits into from
Jan 10, 2024
Merged

B1' derived ef #156

merged 4 commits into from
Jan 10, 2024

Conversation

jordidj
Copy link
Collaborator

@jordidj jordidj commented Dec 7, 2023

PR description

Added the derivative of B1 to the derived eigenfunctions to allow for computation of Delta' for tearing modes.

New features

Legolas

  • New derived ef: dB1

Checklist

  • all tests pass (and for new features, new tests are added)
  • documentation has been updated (if applicable)

@jordidj
Copy link
Collaborator Author

jordidj commented Dec 7, 2023

To do:

  • regenerate derived ef tests
  • bump version number
  • add LaTeX form for dB1 to pylbo

@n-claes
Copy link
Owner

n-claes commented Dec 14, 2023

Poke me if this is ready and I'll give it a review. Failing tests can be simply fixed by bumping the expected number of derived eigenfunctions for the unit tests and regenerating the regression answers for the Couette and Taylor-Couette cases.
You can do this through

pytest test_taylor_couette.py --generate

and then it will ask you to confirm when the tests run. You can add the --keep-files flag as well so it doesn't automatically remove them after testing for visual inspection.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f8c87a) 94.93% compared to head (f22a762) 94.94%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #156   +/-   ##
========================================
  Coverage    94.93%   94.94%           
========================================
  Files          161      161           
  Lines         9138     9155   +17     
========================================
+ Hits          8675     8692   +17     
  Misses         463      463           
Flag Coverage Δ
legolas 93.20% <100.00%> (+0.01%) ⬆️
pylbo 98.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jordidj jordidj requested a review from n-claes January 8, 2024 13:00
@n-claes n-claes added feature Implementation of a new feature legolas-backend Under-the-hood changes to Legolas tests-regression Modified or new regression tests labels Jan 9, 2024
@n-claes
Copy link
Owner

n-claes commented Jan 9, 2024

Looks good -- quick question, for testing purposes I assume that (at least) one of the regression tests you regenerated include a case in which dB1 is non-zero? By this I mean a case where dB1 properly behaves.

Merge when ready :)

@n-claes n-claes assigned n-claes and unassigned n-claes Jan 9, 2024
@n-claes n-claes added this to the Legolas 2.1 milestone Jan 9, 2024
@jordidj
Copy link
Collaborator Author

jordidj commented Jan 10, 2024

dB1 is nonzero and well-behaved in the MRI test case.

@jordidj jordidj merged commit 74f5e07 into develop Jan 10, 2024
10 checks passed
@jordidj jordidj deleted the delta_prime branch January 10, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implementation of a new feature legolas-backend Under-the-hood changes to Legolas tests-regression Modified or new regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants