Merging latest changes from ContactPage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I591026987795d1601e0afd92a1c5a22d4a20984b
Change-Id: I8d7a78c9dd2972bb287376155417ea5a618dbf50
Change-Id: I0ccf74ecc7ca7e8f3a578e1801d8a3ea20be9b8c
Change-Id: Ic795b92d54b07e82dcc18d43e7c78b8d233ccd2d
Change-Id: Id1c13c33f281235f3b323135009ff10b4925f5b5
Change-Id: I50d4ddd554ee638899d3777c1f17fcb988f9699d
Change-Id: I5ac8b7a3b3b5b34bede9a05145b9853f12999394
Change-Id: I73b68f8bb09fb06619817f01412b976d5464ba26
Change-Id: Ifec5836f3c09243545d7492173a359b7199906f7
Change-Id: Iddaff28fa3580cb0c8449dfcbe92853f93232071
Special:Contact does work quite a bit differently than Special:EmailUser, most importantly the sender is usually just something like "Contact Form on Meta". Therefore it makes little sense to use the normal EmailUser hook, if an extension wants to prevent a user from using a contact form, it should implement the ContactForm hook. Bug: T316661 Change-Id: I51eb58e6f188f8db558deb3a220897e60912031e
Change-Id: I055c1f7b5f9322ebae04a8fdca7dd1aa5556586e
Change-Id: Icc57a0e98d9090509a8ec9b1defb892117dcaf1a
Change-Id: I3ecf7e28eaf594c2a6ff7a4e028628ccf86ed1e3
Change-Id: Ic132427bae45c287786945a38465322bc94b5f64
Change-Id: I5b6db1fe2dddc0e61a0f63cf3c781e54502cb396
Change-Id: I35478d610a2f987f100cb39f0a90f15429243acb
Change-Id: I598abbf0e2d99bd27ffac92eb093f9f0156f30a1
Change-Id: I9596accf38ce15816d8036e6f4df005634ffa7e8
* GHSA-f8q6-p94x-37v3 Change-Id: Ia93769e016a22708750e0b896249473c80dc0492
Change-Id: I539f4d5f871486496157ac8000c537ca1fbe19b5
Change-Id: Ice81573040273b813445d4e7084194121706afad
Change-Id: I3bee2d4afa1244fe3a2b0d641aac8174e79c4011
Change-Id: I9c48252a2ee28dae223a0b94fa948bcc2d006500
UserMailer::send defaults to plain/text and only outputs HTML if the body element is an array with an 'html' key. This extension's email messages are always strings, which UserMailer::send treats as plain/text. The Phan build checks that potential HTML entities are escaped before output, but the text output by this extension is always plain text which does not need escaping. This leads to build failures that need to be suppressed. Change-Id: Ide6773e54b99737b1a06dab6e84add329ddc1692
Change-Id: I3aac5cdb6913c0aefb86427e1ba9d42a073f478a
Bug: T324112 Change-Id: I3a935309ca3fcc80341ab4b8a04e3ff7f17618da
Set up selenium testing on ContactPage and create the first test that checks to see if the extension has been loaded and is visible on Special:Version. This will be removed once other selenium tests have been added, and is to ensure that the selenium tests are working as expected. Bug: T186864 Change-Id: I56cba33f9467957f407c1a441c9c3d7867cbe2a5
Change-Id: If1f8ffb540f4869baa062f72fb38c006367ec64a
Change-Id: Ia3eabdf16811d420e8cda9919520a479f8f4435e
Change-Id: I03dcb0da3442429b15cfad7a3c55831b8b7d1b55
Change-Id: I5f2147f143905d0232b2bee03257471653c077a5
Change-Id: I9d201df368e4c9314a76c1839c1ec5311e4aabb4
Change-Id: I3e2867c3a19e369954b3173f8210ad1fd5ab33b6
Change-Id: I0d31994005a83f9ffa3fccd6397bd54560124f62
Bug: T381661 Change-Id: I55cb47246372aa964b15cea72fe06817a962ebdb
Currently Additional form fields defined by a form configuration are always sandwiched between some stock fields defined by the extension. These stock fields cannot be removed or moved to another place, despite the fact that none of them is inherently required for the form to work. Add MergeStrategy form parameter to allow forms greater control on placement of their additional fields with respect to the stock ones as well as redefining or unsetting unwanted stock fields. Also expand test cases to cover the main features of the parameter: 1. Stock fields can be removed 2. Stock fields can be repositioned 3. Control fields cannot be removed or re-positioned 4. Attributes on Field definition take precedence over formconfig-level attributes that do the same thing Bug: T377122 Change-Id: Iee2639f0d8f6393c73ff178912eb61c15d293e87
SpecialContact needs additional testing, and this commit expands these tests. Bug: T381661 Change-Id: I238cd1a6c99be7a438ac7936230bef365d16f181
* mocha: 10.2.0 → 10.8.2 * GHSA-mwcw-c2x4-8c55 * nanoid: 3.3.3 → * GHSA-mwcw-c2x4-8c55 Change-Id: I78d7f915aaf475692dd9e714ab2089491019469a
Change-Id: I9c5fb36bc8af51a4cddddab64ebf593822e19021
Change-Id: I642eb04ed5ebce92fca52c7957eef2c7ea5b7fb1
Change-Id: I03d067e19e4d74eeec78ae995827efea999bf22d
Change-Id: Ie6107730b67c597c64ef7b881e6107ea48eea22a
Return the returned promise from Page.openTitle to the caller Follow-Up: Idd72732a749ee6657a8617cc0ecc7ab9f6217a69 Change-Id: Iff9bf5220ffcfb8d56284b9070a14d9b0ffea966
Change-Id: I1f1aa1f25ffa35823135f21bce11ac25911f442e
Change-Id: I0c2574fdaf09699301a21c609b3d14758b9a4534
Change-Id: I9cc9ace500f061105ccf05ad2667b42ee81db98b
Change-Id: Ie12c2d924dac8d0d044bf09ed334be39e2cec5e7
Change-Id: I670886808b23fc0b4d86a24c2ffdef1f95bfd25d
Change-Id: Iac4511402ab3d4428601f3bcab7956c0a2ac9e2a
Change-Id: I1ec6ae50e1cfca4df1268ee22319ebe7769ccf0c
Change-Id: I0b5f620c301352b70409cc9190b018d8b6163774
Change-Id: Ifa28a8c11f5c5cb0a3448ae281265eec3dec9592
Change-Id: I761e3f8cf9357932c75a71b4b260b916f752d2e6
Change-Id: I10a3c20316b4903fe28605c1be1dea53fb2f49a0
Change-Id: I6d91b90f88c30386168468dbc1081a6cc75d2fd9
Change-Id: I357eb3ecdf80ae7c4bd6623a251cb8f35dc825fa
Change-Id: Id2f96037a7bc34a3255bc8ff484e69047d0a2f53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.