Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get input image shape statically in the model construction function #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LucasMahieu
Copy link
Contributor

Instead of using input.get_shape() fonction
We can pass input image shape to yolo_v3 and yolo_v3_tiny constructor
function.
Since the input placeholder shape is statically defined (to None, size, size, 3)
We can have access to this 'size' when constructing the yolo_v3 or
yolo_v3_tiny models.

This if more efficient for inference.
This commit should not break any anterior codes since it is only adding
1 optional argument to model constructor functions

Instead of using input.get_shape() fonction
We can pass input image shape to yolo_v3 and yolo_v3_tiny constructor
function.
Since the input placeholder shape is statically defined (to None, size, size, 3)
We can have access to this 'size' when constructing the yolo_v3 or
yolo_v3_tiny models.

This if more efficient for inference.
This commit should not break any anterior codes since it is only adding
1 optional argument to model constructor functions
There was a bug in the way the all zero prediction was removed from the
image_prediction tensor

This solution is correct, much more simple and clear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant