Fixed extra characters when parsing comments rows #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jifeon
suggested changes
Nov 1, 2021
index.js
Outdated
| @@ -5,15 +5,16 @@ const recursiveReadDir = require('recursive-readdir') | |||
|
|
|||
| function parseComments(file) { | |||
| const lines = file.split('\n'), require = [] | |||
| const extraCharactersRegexp = new RegExp(/[\r\n]/) | |||
There was a problem hiding this comment.
isn't file.split(/\r?\n/) solve the issue?
devdevdenis
force-pushed
the
fix-extra-characters
branch
from
3261f75 to
7de3f92
Compare
jifeon
approved these changes
Nov 1, 2021
|
@michael-bogdanov can we merge it to make work on windows a bit simpler? |
|
@michael-bogdanov if you take a look at latest commits in this repo, they are made by guys from Plyo: Any chance you can make me a maintainer of this repo, so we can stop using our fork and merge everything more efficiently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows system I faced with strange behavior, when specify comment about required entity. After debugging I found problem. This is related to
\rsymbol which breaks required paths. Suggested solution is remove all extra symbols inrequireanddrop codecomments