Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python add poetry #1815

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Python add poetry #1815

wants to merge 5 commits into from

Conversation

ajparsons
Copy link
Contributor

Stage one of #1813

  • requirements.txt replaced with Poetry (will need feature enabled before deploy to server)
  • Creates a src/twfy_tools that acts as the common library for features.
  • Config for ruff as a formatter/linter.
  • Wrapper for config (lets IDE see values and type)
  • Common DB access function.

@ajparsons
Copy link
Contributor Author

ajparsons commented Sep 25, 2024 •
edited
Loading

Before deploy need to add poetry to the relevant role in puppet so then it’s installed on the server, add the relevant user to profiles::python::poetry::users - have a look at, for example, data/roles/climate.yaml (in the Puppet repo)

@ajparsons ajparsons force-pushed the python-add-poetry branch 2 times, most recently from 4eb83fc to 9d7779f Compare October 1, 2024 12:14
@ajparsons
Setup basic python structure
3356962 
- switch to poetry based approach
- create new python data using src
- configure linting via ruff
- vscode settings update
@ajparsons
Add nicer python config access
7680b2e 
- Wrap commonlib config access in a pydantic model
- Transform types and reveal settings to python IDE
@ajparsons
Add mysql connection module
f7dc27c 
- include sqlalchemy engine for pandas
@ajparsons
Extend Ruff to scripts dir
24b3ced
@ajparsons ajparsons requested a review from struan October 1, 2024 12:25
@ajparsons ajparsons force-pushed the python-add-poetry branch 4 times, most recently from da6353f to d230d3e Compare October 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@struan struan Awaiting requested review from struan

Assignees

@struan struan

@ajparsons ajparsons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajparsons @struan