Store multiple comms opt-ins in database #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
approved these changes
Oct 20, 2023
- $optin is decoded and encoded to three seperate booleans - basic conversions from bool to int removed - Multiple options added to join and edit page - Form formatting tidied up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we store a single comms opt-in, but have changed what this means over time.
This PR repurposes the current optin database value to store multiple different types of comms optin.
Basically this covers:
We might want to do less than that or change the text - but wanted to get the technical side signed off.
Technically this has removed several steps converting a binary value to a 0/1 and added functions to store and retriveve values as different bits in the one tinyint available (technically can do up to 8).
I've tested creating new users, and modifying when logged in.