-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for import scripts #613
Open
zarino
wants to merge
8
commits into
main
Choose a base branch
from
import-areas-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2b5dfd9 - Browse repository at this point
Copy the full SHA 2b5dfd9View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c290e0 - Browse repository at this point
Copy the full SHA 5c290e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56accf3 - Browse repository at this point
Copy the full SHA 56accf3View commit details
Commits on Sep 24, 2024
-
Update import scripts to handle 2010 constituencies again
We removed 2010 WMC constituencies from the import scripts back in July, because we figured all 2010 data had already been imported into the live site, and we wouldn’t need to import any more. But it’s actually useful to be able to recreate the situation of the live site (with multiple generations of WMCs) in local development too, which means we need the import scripts to keep working with WMCs, rather than relying on developers just having the right data already in their local environments. This commit reinstates the WMC (rather than WMC23) AreaType, and updates our mapit utility function to accept a `generation` parameter that will easily allow us to change the MapIt generation in future again too. With both 2010 and 2023 constituencies coming straight from MapIt now, there is no longer any need for the import_new_constituencies command.
Configuration menu - View commit details
-
Copy full SHA for 066a975 - Browse repository at this point
Copy the full SHA 066a975View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90fe225 - Browse repository at this point
Copy the full SHA 90fe225View commit details -
Fix import scripts that failed when run with multiple AreaTypes
These import scripts all used QuerySet.get() insted of QuerySet.filter() which was causing an exception when both WMC and WMC23 AreaTypes were present in the database.
Configuration menu - View commit details
-
Copy full SHA for 4d758cf - Browse repository at this point
Copy the full SHA 4d758cfView commit details -
Skip broken/outdated import scripts in run_all_import_scripts
Also, run the scripts alphabetically for easier debugging.
Configuration menu - View commit details
-
Copy full SHA for ba32ae1 - Browse repository at this point
Copy the full SHA ba32ae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for de43867 - Browse repository at this point
Copy the full SHA de43867View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.