Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[offline] Cache inspector reports sequentially, not in parallel #5204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davea
Copy link
Member

@davea davea commented Oct 3, 2024

For extremely long lists of planned reports this was causing load issues.

For extremely long lists of planned reports this was
causing load issues.
@davea davea requested a review from dracos October 3, 2024 13:23
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks, yep, looks good, one comment on whether images need it, but yeah, probably safer (wonder how slow it'll be).

web/cobrands/fixmystreet/offline.js Show resolved Hide resolved
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (4610b20) to head (e8fa9ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5204   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files         407      407           
  Lines       31795    31795           
  Branches     5059     5059           
=======================================
+ Hits        26203    26204    +1     
+ Misses       4096     4095    -1     
  Partials     1496     1496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davea
Copy link
Member Author

davea commented Oct 3, 2024

Performance for 100 reports here is about the same, though strangely using the old code the counter in the banner sat at 0/100 for a long time before suddenly whizzing through to 100, whereas the new code it ticked up quite steadily as soon as the page loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants