[Bexley][WW] Only skip parent addresses if they are marked as 'shell' properties #5203
+33
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties We were skipping over all parent addresses on the assumption that all were 'shell' addresses that shouldn't be displayed. But the 'shell' status only applies to some parents.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5203 +/- ##
==========================================
- Coverage 82.41% 82.22% -0.20%
==========================================
Files 407 409 +2
Lines 31789 32509 +720
Branches 5059 5101 +42
==========================================
+ Hits 26199 26729 +530
- Misses 4094 4272 +178
- Partials 1496 1508 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nephila-nacrea
commented
Oct 3, 2024
| ); | ||
| } | ||
| } | ||
|
|
||
| # It is possible for UPRNs in child_uprns to not occur in the postcodes table |
There was a problem hiding this comment.
Turns out that the P/PP check fixes this issue as well, so have deleted this portion.
…'shell' properties
nephila-nacrea
force-pushed
the
FD-4432-bexley-ww-parent-shells
branch
from
6ac8cb6
to
c933474
Compare
…ked as 'shell' properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were skipping over all parent addresses on the assumption that all were 'shell' addresses that shouldn't be displayed. But the 'shell' status only applies to some parents.
For https://mysocietysupport.freshdesk.com/a/tickets/4432.
Closes https://github.com/mysociety/societyworks/issues/4498.
[skip changelog]