[Bexley][WW] Display additional missed report details on confirmation page #5200
+121
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page Similar to what we display in the emails.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5200 +/- ##
==========================================
- Coverage 82.41% 82.39% -0.03%
==========================================
Files 407 408 +1
Lines 31789 32266 +477
Branches 5059 5081 +22
==========================================
+ Hits 26199 26584 +385
- Misses 4094 4186 +92
Partials 1496 1496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dracos
requested changes
Oct 3, 2024
| @@ -840,6 +840,9 @@ sub group_reports { | |||
| my $report = shift @reports; | |||
| if (@reports) { | |||
| $report->set_extra_metadata(grouped_ids => [ map { $_->id } @reports ]); | |||
| $report->set_extra_metadata( | |||
| grouped_titles => [ map { $_->title } @reports ] ) | |||
| if $c->cobrand->call_hook('group_report_titles'); | |||
There was a problem hiding this comment.
I'm happy not to have this hook, just set it always, doesn't matter :)
There was a problem hiding this comment.
Yeah, I can remove this, makes the code simpler.
…n confirmation page
nephila-nacrea
force-pushed
the
FD-4606-bexley-ww-missed-collection-confirmation
branch
from
47a38b5
to
a9fb62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we display in the emails.
For https://mysocietysupport.freshdesk.com/a/tickets/4606.
[skip changelog]