-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parish councils #5198
Add parish councils #5198
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5198 +/- ##
==========================================
+ Coverage 82.33% 82.35% +0.02%
==========================================
Files 409 409
Lines 32012 32001 -11
Branches 5101 5095 -6
==========================================
- Hits 26357 26356 -1
+ Misses 4142 4137 -5
+ Partials 1513 1508 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Struggling to focus on this at the moment so may try to come back to it later. Have a few comments so far.
529c56a
to
20bf0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌳 🛝 ❗ 🆗
This adds a configuration value containing the MapIt IDs of parish areas for which we want to be able to add bodies in the system. Include the Bucks parishes by default.
20bf0ae
to
506d2bd
Compare
Fixes #160 [skip changelog]
This adds the ability to add parish council bodies to .com (with a manual allow list rather than having them all appear in the area dropdown on the body page), and also allows parish council alert updates everywhere, regardless of if bodies exist for them or not.
It updates the alert sign up page to have it one column, ordered by area rather than destination, and fixes a bug where you signed up for a different body than it said in Brent/Camden type areas.This part has been merged.