Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parish councils #5198

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add parish councils #5198

merged 2 commits into from
Oct 25, 2024

Conversation

dracos
Copy link
Member

@dracos dracos commented Oct 1, 2024

Fixes #160 [skip changelog]

This adds the ability to add parish council bodies to .com (with a manual allow list rather than having them all appear in the area dropdown on the body page), and also allows parish council alert updates everywhere, regardless of if bodies exist for them or not.

It updates the alert sign up page to have it one column, ordered by area rather than destination, and fixes a bug where you signed up for a different body than it said in Brent/Camden type areas. This part has been merged.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.35%. Comparing base (02685b3) to head (506d2bd).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/UK.pm 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5198      +/-   ##
==========================================
+ Coverage   82.33%   82.35%   +0.02%     
==========================================
  Files         409      409              
  Lines       32012    32001      -11     
  Branches     5101     5095       -6     
==========================================
- Hits        26357    26356       -1     
+ Misses       4142     4137       -5     
+ Partials     1513     1508       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nephila-nacrea nephila-nacrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Struggling to focus on this at the moment so may try to come back to it later. Have a few comments so far.

perllib/FixMyStreet/App/Controller/Alert.pm Outdated Show resolved Hide resolved
perllib/FixMyStreet/App/Controller/Alert.pm Outdated Show resolved Hide resolved
perllib/FixMyStreet/App/Controller/Council.pm Show resolved Hide resolved
perllib/FixMyStreet/App/Controller/Reports.pm Outdated Show resolved Hide resolved
Copy link
Member

@davea davea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳 🛝 ❗ 🆗

@dracos dracos removed the request for review from chrismytton October 25, 2024 09:32
This adds a configuration value containing the MapIt IDs of parish areas
for which we want to be able to add bodies in the system.

Include the Bucks parishes by default.
@dracos dracos merged commit 506d2bd into master Oct 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parish councils
3 participants