[Northumberland] Fetch 'detailed_information' (extra details) to/from Alloy & assigned user to Alloy #5147
+338
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5147 +/- ##
=========================================
Coverage ? 82.51%
=========================================
Files ? 406
Lines ? 31732
Branches ? 5049
=========================================
Hits ? 26185
Misses ? 4056
Partials ? 1491 ☔ View full report in Codecov by Sentry. |
nephila-nacrea
force-pushed
the
nland-assigned-to-extra-details
branch
3 times, most recently
from
224a88b
to
828c26e
Compare
nephila-nacrea
changed the title
nephila-nacrea
changed the title
nephila-nacrea
force-pushed
the
nland-assigned-to-extra-details
branch
2 times, most recently
from
bb6d52d
to
10ac3cd
Compare
dracos
requested changes
Sep 11, 2024
nephila-nacrea
force-pushed
the
nland-assigned-to-extra-details
branch
from
10ac3cd
to
818dabf
Compare
dracos
force-pushed
the
nland-assigned-to-extra-details
branch
2 times, most recently
from
c02aed2
to
de608ee
Compare
dracos
force-pushed
the
nland-assigned-to-extra-details
branch
from
de608ee
to
702d107
Compare
nephila-nacrea
commented
Sep 23, 2024
There was a problem hiding this comment.
The one thing I've noticed is that we still show (e.g.) 'User shortlisted: [email protected]' updates, I feel we should hide those too. Which is something I could look at.
Edit: Never mind, the 'NOT update.text' check covers that, I just had old comments for shortlisted users that did have text 🤦♀️
dracos
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://mysocietysupport.freshdesk.com/a/tickets/3082 / https://github.com/mysociety/societyworks/issues/4507.
[skip changelog]