[Bexley][WW] Allow user to request new containers #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5111 +/- ##
==========================================
+ Coverage 82.41% 82.96% +0.54%
==========================================
Files 409 410 +1
Lines 32073 33272 +1199
Branches 5118 5459 +341
==========================================
+ Hits 26432 27603 +1171
- Misses 4122 4140 +18
- Partials 1519 1529 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nephila-nacrea
force-pushed
the
bexley-ww-container-requests
branch
from
0f87b08
to
6619f11
Compare
nephila-nacrea
force-pushed
the
bexley-ww-container-requests
branch
from
6619f11
to
bf29854
Compare
nephila-nacrea
force-pushed
the
bexley-ww-container-requests
branch
from
bf29854
to
2460d7d
Compare
nephila-nacrea
changed the title
dracos
force-pushed
the
bexley-ww-container-requests
branch
2 times, most recently
from
99bbc13
to
41457d7
Compare
dracos
force-pushed
the
bexley-ww-container-requests
branch
from
82e1602
to
903aff9
Compare
dracos
force-pushed
the
bexley-ww-container-requests
branch
2 times, most recently
from
cec6990
to
68a3ded
Compare
Can be standalone or done as part of the delivery request flow
dracos
force-pushed
the
bexley-ww-container-requests
branch
from
68a3ded
to
5bb8860
Compare
Also renamed final 'submit' to reflect that request is not just for new containers.
…form We had not handled cases where the container has a 'parent' (i.e. wheelie bin with different size options), nor handled removal options.
For clear sack deliveries.
…es' into bexley-ww-container-requests
…y and removal form
nephila-nacrea
commented
Nov 20, 2024
| @@ -15,7 +15,7 @@ <h3>More services</h3> | |||
| <li><a [% external_new_tab | safe %] href="[% c.uri_for_action('waste/request', [ property.id ]) %]?request_type=removal">Order removal of old bins</a></li> | |||
| [% END %] | |||
| [% IF property.has_boxes %] | |||
| <li><a [% external_new_tab | safe %] href="[% c.uri_for_action('waste/request', [ property.id ]) %]?request_type=delivery&container-Deliver-Box-lids-55L=1">Order lids for recycling boxes</a></li> | |||
| <li><a [% external_new_tab | safe %] href="[% c.uri_for_action('waste/request', [ property.id ]) %]?request_type=delivery&container-Deliver-Box-lids-55L=1">Order lids for recycling boxes</a></li> | |||
There was a problem hiding this comment.
Why is the amp; needed here?
There was a problem hiding this comment.
An ampersand declares the start of a special character; if instead of container after it you'd had, dunno, =delivery&hearts=1, then the HTML output would actually be delivery♥=1. So & should be escaped in HTML output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 'base' branch for code for Bexley's container maintenance project (https://github.com/mysociety/societyworks/milestone/116) before putting everything live.
[skip changelog]