Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8369] Remove "All time" filter from admin timeline #8370

Closed
wants to merge 1 commit into from

Conversation

garethrees
Copy link
Member

On WhatDoTheyKnow this loads 17 million+ events, which attempts to use over 5GB of memory.

In all but the smallest installs pagination will be required for this page to be performant, so this commit removes the filter entirely.

Fixes #8369.

BEFORE

Screenshot 2024-08-29 at 16 54 26

AFTER

Screenshot 2024-08-29 at 16 54 18

On WhatDoTheyKnow this loads 17 million+ events, which attempts to use
over 5GB of memory.

In all but the smallest installs pagination will be required for this
page to be performant, so this commit removes the filter entirely.

Fixes #8369.
Copy link
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 This isn't necessary. We need to correctly past in the offset/limit options to the query and we can keep this option.

@gbp
Copy link
Member

gbp commented Nov 19, 2024

Closing in favour of #8458

@gbp gbp closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak viewing all events in admin timeline
2 participants