Fixes for the macOS retina display and dark theme #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes interaction with OpenGL graphs used, for example, in the FFT View module of the LimeSuiteGUI. This includes: - Zoom in by mouse-drag, where the zoom border used to be using wrong coordinates. - Panning, which used to happen at half the mouse speed. - Adding markers, which used to be added at a wrong location. The issue was happening on the macOS with Retina displays. This is a port of myriadrf/LimeSuite@49880e7f865 from the original LimeSuite repository.
When the Lime Suite GUI is used on a macOS which is default to the dark mode the information logged into the log window was hard to read: it was defaulting to the black foreground. The behavior now matched when no SetDefaultStyle() used at all: the light theme will use black text, and the dark theme will use the white color. The limitation this change does not address is the update of the colors in the log window when the theme is changed between dark ans light while the limeGUI is running. This is a port of myriadrf/LimeSuite@884070e490a and myriadrf/LimeSuite@cc09db1f9b0 from the LimeSuite repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of the fixes previously made to the LimeSuite repository:
The latter two are squished together since they are actually related to each other.
This fixes mouse behavior in the OpenGL graph on Retina displays which has a difference between logical and physical pixels. It also fixes text in the mini log always being black which is hard to read when using dark macOS theme.
The PR consists of two consecutive commits to make it easier to track, if needed.