Dockerfiles #3
Open
Dockerfiles #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pr/670: Remove redundant junits dependencies Closes spring-projectsgh-670
* pr/650: Upgrade to wro4j 1.9.0 Closes spring-projectsgh-650
Updated creation of user for mysql db. Previously lack of quotes resulted in creation of incorrect user (petclinic@% instead of just petclinic)
This commit downgrades the wro4j plugin to 1.8.0 as the latest version requires Java 11. See spring-projectsgh-707
* pr/707: Downgrade to wro4j 1.8.0 remove .vscode folder from project repository Closes spring-projectsgh-707
As part of a process to build a BOSH release, I encountered the error below while running `./mvnw package`: ``` [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:3.0.1:revision (default) on project spring-petclinic: Could not complete Mojo execution...: Error: Could not get HEAD Ref, are you sure you have set the dotGitDirectory property of this plugin to a valid path? -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException ``` That's because we are just interested on the source files for the BOSH release, we don't care about repo metadata (so we exclude them). Going through the [git-commit-id-maven-plugin docs](https://github.com/git-commit-id/git-commit-id-maven-plugin/blob/master/maven/docs/using-the-plugin.md) we learned it is possible to prevent the failure above via configuration. We propose then to set `<failOnUnableToExtractRepoInfo>false</failOnUnableToExtractRepoInfo>`, enabling use cases similar to ours. FWIW `failOnNoGitDirectory` is already set to false.
Signed-off-by: Jinbo Wang <[email protected]>
kerimovkhikmet
force-pushed
the
feature
branch
from
2dcd6da to
db6525b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had added Dockerfiles for app and db containers. Started on working with docker-compose.