Merge pull request #84 from mynaparrot/api_change

impl: new api changes
mynaparrot · May 3, 2024 · a1721ae · a1721ae
2 parents 540e102 + d98b18c
commit a1721ae
Show file tree

Hide file tree

Showing 10 changed files with 37 additions and 7 deletions.
diff --git a/deno_dist/PlugNmeet.ts b/deno_dist/PlugNmeet.ts
@@ -129,6 +129,7 @@ export class PlugNmeet implements PlugNmeetAPI {
 
     return {
       status: output.response.status,
+      is_active: output.response.is_active,
       msg: output.response.msg,
     };
   }

diff --git a/deno_dist/examples/quickJoin.ts b/deno_dist/examples/quickJoin.ts
@@ -65,9 +65,15 @@ let isRoomActive = false,
 const res = await pnm.isRoomActive({
   room_id: roomId,
 });
-isRoomActive = res.status;
 
-if (!isRoomActive) {
+if (!res.status){
+  hasError = true;
+  console.log(res.msg);
+}else if (typeof res.is_active !== "undefined"){
+  isRoomActive = res.is_active;
+}
+
+if (!isRoomActive && !hasError) {
   const res = await pnm.createRoom(roomInfo);
   if (!res.status) {
     hasError = true;

diff --git a/deno_dist/types/createRoom.ts b/deno_dist/types/createRoom.ts
@@ -12,6 +12,8 @@ export type RooMetadata = {
   logout_url?: string;
   room_features: RoomFeaturesParams;
   default_lock_settings?: LockSettingsParams;
+  copyright_conf?: CopyrightConf;
+  extra_data?: string;
 };
 
 export type RoomFeaturesParams = {
@@ -119,3 +121,8 @@ export type CreateRoomResponseRoomInfo = {
   enabled_codecs: Array<any>;
   metadata: string;
 };
+
+export type CopyrightConf = {
+  display: boolean;
+  text: string;
+}
diff --git a/deno_dist/types/isRoomActive.ts b/deno_dist/types/isRoomActive.ts
@@ -4,5 +4,6 @@ export type IsRoomActiveParams = {
 
 export type IsRoomActiveResponse = {
   status: boolean;
+  is_active?: boolean;
   msg: string;
 };
diff --git a/examples/quickJoin.js b/examples/quickJoin.js
@@ -66,9 +66,15 @@ const plugNmeet = require('../').PlugNmeet;
   let res = await pnm.isRoomActive({
     room_id: roomId,
   });
-  isRoomActive = res.status;
 
-  if (!isRoomActive) {
+  if (!res.status){
+    hasError = true;
+    console.log(res.msg);
+  }else if (typeof res.is_active !== "undefined"){
+    isRoomActive = res.is_active;
+  }
+
+  if (!isRoomActive && !hasError) {
     res = await pnm.createRoom(roomInfo);
     if (!res.status) {
       hasError = true;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plugnmeet-sdk-js",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "description": "plugNmeet JS SDK",
   "author": "Jibon L. Costa",
   "license": "MIT",

diff --git a/src/PlugNmeet.ts b/src/PlugNmeet.ts
@@ -126,6 +126,7 @@ export class PlugNmeet implements PlugNmeetAPI {
 
     return {
       status: output.response.status,
+      is_active: output.response.is_active,
       msg: output.response.msg,
     };
   }

diff --git a/src/types/createRoom.ts b/src/types/createRoom.ts
@@ -12,6 +12,8 @@ export type RooMetadata = {
   logout_url?: string;
   room_features: RoomFeaturesParams;
   default_lock_settings?: LockSettingsParams;
+  copyright_conf?: CopyrightConf;
+  extra_data?: string;
 };
 
 export type RoomFeaturesParams = {
@@ -119,3 +121,8 @@ export type CreateRoomResponseRoomInfo = {
   enabled_codecs: Array<any>;
   metadata: string;
 };
+
+export type CopyrightConf = {
+  display: boolean;
+  text: string;
+};
diff --git a/src/types/isRoomActive.ts b/src/types/isRoomActive.ts
@@ -4,5 +4,6 @@ export type IsRoomActiveParams = {
 
 export type IsRoomActiveResponse = {
   status: boolean;
+  is_active?: boolean;
   msg: string;
 };