Fix native build #87
Open
Fix native build #87
+15
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark the script as executable. - Fix the current-directory check to match this repo. - Fix the git hashes (they were missing from the repos). - Uncomment the git hashes (this was a syntax error).
We are trying to use this source for React Native, but React Native does not have Emscripten. Fortunately, the header isn't actually needed.
swansontec
force-pushed
the
fix-native-build
branch
from
f971456
to
c8b2b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried building the WASM bundle following the instructions in @mymonero/mymonero-monero-client, but ran into errors.
This pull request fixes the problems I ran into with the prepare script,
and then hacks around the remaining C++ compiler errors. The C++ hacks are almost certainly the wrong solution, but I cannot find the matching branch in mymonero-core-cpp with the correct solution. If you know where that code is, I would be happy to update the PR.Edit: I found the correct code in the
webassembly-cleanupbranch, so I dropped the hacks from the PR. This is now clean & ready to merge.I also have some comment updates and an unnecessary header removal. These are useful in any case, so I could submit them as a separate PR if you don't want to mix these cleanups with the build fixes.