Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove firefox/nautilus from mandatory packages + use options.sh to install browser/filemanager post-install #674

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

redsh4de
Copy link

@redsh4de redsh4de commented Feb 3, 2025

Instead of installing firefox & nautilus and setting them as defaults, this change will make it so the browser & file manager can be chosen by the user after installation of ML4W. This accounts for users that may already have browsers installed that they want to use, or those who do not wish to use a browser at all.

Instead of adding extra files/bloat to the codebase, this solution uses a slightly modified version of options.sh to allow targeted installs of additional packages without going through the initial menu

Changes made:

  • Allow directly passing which package to modify for nl4w-options
  • Removes firefox & nautilus from default packages
  • Edited browser.sh and filemanager.sh to point to nl4w-options with the additional parameter by default
  • Changes to all options files to ensure backwards compatibility
  • Modified the waybar links, changed firefox icon to universal "web" icon

@ArekKubinski
Copy link

Is there a way to retain firefox icon on waybar if the web browser is firefox? I really like my firefox icon and would pain me if I had to hack together a replace string script in post.sh

@redsh4de
Copy link
Author

redsh4de commented Feb 3, 2025

Is there a way to retain firefox icon on waybar if the web browser is firefox? I really like my firefox icon and would pain me if I had to hack together a replace string script in post.sh

Can definitely be done, i'll replace the default browser icon with the firefox icon if it is the chosen option in the options wizard.

…nstalled

- allowed Ctrl+C to exit the scripts when launched directory
@redsh4de
Copy link
Author

redsh4de commented Feb 3, 2025

@ArekKubinski This will now automatically update both the tooltip and icon whenever the browser is switched via ML4W options. (Currently the default font seems to only support firefox and chrome icons though)

@mylinuxforwork
Copy link
Owner

@redsh4de With the latest push, firefox and nautilus will be only installed with an initial installation. I will look into your improvements.

@redsh4de
Copy link
Author

redsh4de commented Feb 3, 2025

@mylinuxforwork Sounds good!

Regarding the 'unorthodox' way the icon/name are replaced in waybar-quicklinks.json - i did plan to use jq initially, but it doesn't support the json5/hjson syntax with comments, so using a combo of common gnu utils was the best alternative so that no additional packages need to be installed

@mylinuxforwork
Copy link
Owner

@redsh4de Thanks for your updates. I have just pushed an more readable version of the quicklinks.json to the main branch.

I will look into your options updates later after the release of 2.9.8

- add e-mail client to options menu
- show (none) in defaults when no email client is defined in the setting script
@redsh4de
Copy link
Author

redsh4de commented Feb 5, 2025

@mylinuxforwork Gotcha! Yea the script will still work all the same, as it would look for the parent JSON object containing browser.sh

I also noticed that now email is included in the waybar, so i added e-mail installation options to the options.sh script + packages for both arch and fedora

@fesowowako
Copy link
Contributor

@mylinuxforwork I believe this pull request is ready to be merged as it appears clean and serves its purpose, but that's just my take on it. Ultimately, the decision is yours.

@mylinuxforwork
Copy link
Owner

@redsh4de Not able to test it before the release of 2.9.8.0 I will check again for 2.9.8.1. Hope that's Ok for you.

@redsh4de
Copy link
Author

redsh4de commented Feb 7, 2025

@mylinuxforwork Sure thing!

redsh4de added 5 commits February 7, 2025 21:27
- changed the fallback browser icon to the up-to-date one
- fixed a bug for selecting the file manager
- set options/email.sh to be the email client option installer by default
@redsh4de
Copy link
Author

@mylinuxforwork This should now be up to date with the changes made since the previous releases

@redsh4de
Copy link
Author

@mylinuxforwork Any opportunity to test the updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants