feat: add new scene transition methods #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 92.63% 93.07% +0.44%
==========================================
Files 22 22
Lines 733 780 +47
==========================================
+ Hits 679 726 +47
Misses 54 54 ☔ View full report in Codecov by Sentry. |
|
@Clozent could you take a look at the PR and check whether it fits the expectations? |
|
I am currently unable to test and confirm for myself, but after taking a glance at the code, I think this is awesome! The method names are a bit long, but this is just an aesthetic issue for me. I don't think there are better names for these methods anyways, but I wanted to point that out, in any case. |
joaoborks
pushed a commit
that referenced
this pull request
Aug 27, 2024
# [3.1.0](3.0.2...3.1.0) (2024-08-27) ### Features * add new scene transition methods ([#46](#46)) ([de9ccb7](de9ccb7))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
* update scene loader interface * add new transitions to scene loaders * add transitiontoscenesfromscenes test * add transitiontoscenesfromall test * add documentation for new transition methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new scene transition methods as suggested on #45:
TransitionToScenesFromScenes- unloads a group of scenes in the transitionTransitionToScenesFromAll- unloads all loaded scenes in the transitionProgress