Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and warnings regarding Awake() limitations #43

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

joaoborks
Copy link
Member

Implements comments mentioned in #42

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (7dc5641) to head (2e7dbe2).
Report is 2 commits behind head on main.

Files Patch % Lines
...tools.scene-loader/Runtime/AdvancedSceneManager.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   93.14%   92.63%   -0.51%     
==========================================
  Files          22       22              
  Lines         729      733       +4     
==========================================
  Hits          679      679              
- Misses         50       54       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaoborks joaoborks merged commit cd08e40 into main Aug 16, 2024
6 checks passed
@joaoborks joaoborks deleted the fix/improve-awake-docs branch August 16, 2024 01:45
joaoborks pushed a commit that referenced this pull request Aug 16, 2024
## [3.0.2](3.0.1...3.0.2) (2024-08-16)

### Bug Fixes

* add warning and documentation regarding Awake() ([#43](#43)) ([e24423d](e24423d))
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
## [3.0.2](3.0.1...3.0.2) (2024-08-16)

### Bug Fixes

* add warning and documentation regarding Awake() ([#43](#43)) ([e24423d](e24423d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentException: Attempted to get an ISceneData through an invalid or unloaded scene.
1 participant