fix: scene linking for scenes loaded by path #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 93.01% 93.14% +0.12%
==========================================
Files 22 22
Lines 730 729 -1
==========================================
Hits 679 679
+ Misses 51 50 -1 ☔ View full report in Codecov by Sentry. |
joaoborks
pushed a commit
that referenced
this pull request
Jul 31, 2024
## [3.0.1](3.0.0...3.0.1) (2024-07-31) ### Bug Fixes * scene linking for scenes loaded by path ([#41](#41)) ([7dc5641](7dc5641))
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
* fix loading scenes by path * improve loadsceneinfoname debug name
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
## [3.0.1](3.0.0...3.0.1) (2024-07-31) ### Bug Fixes * scene linking for scenes loaded by path ([#41](#41)) ([7dc5641](7dc5641))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
In version
2.x, the standard (non-addressable) scenes were never linked to their load scene info. In version3.xthe package introduced scene linking, but did not account for scenes loaded by path.This PR includes support for scene linking when loading scenes by path and includes scenes loaded by path in all existing tests.