fix: down command handle exception (#84)

__tests__/down.test.ts

@@ -18,6 +18,7 @@ import { MigrationInterface } from '../lib/MigrationInterface';
 import { loadMigrationFile } from '../lib/migrations';
 import { configMock } from './__mocks__/config.mock';
 import { connectionMock } from './__mocks__/connection.mock';
+import { ExecuteMigrationError } from '../lib/errors';
 
 describe('down command', () => {
   const numberOfMigrations = 10;
@@ -74,4 +75,21 @@ describe('down command', () => {
     expect(deleteMigration).toBeCalledTimes(1);
     expect(connectionMock.client.close).toBeCalled();
   });
+
+  it('should handle exception when migration down fails', async () => {
+    (fakeMigrationInstance.down as jest.Mock).mockReturnValue(
+      new Promise((_, reject) => reject('Error'))
+    );
+
+    type Mode = 'all' | 'last';
+    const modes: Mode[] = ['all', 'last'];
+
+    for await (const mode of modes) {
+      const downOperation = () => down({ mode, config: configMock });
+
+      await expect(downOperation()).rejects.toThrow(ExecuteMigrationError);
+      expect(deleteMigration).toBeCalledTimes(0);
+      expect(connectionMock.client.close());
+    }
+  });
 });

lib/commands/down.ts

@@ -9,6 +9,7 @@ import {
   MigrationModel,
   mongoConnect,
 } from '../database';
+import { ExecuteMigrationError } from '../errors';
 import { MigrationObject, loadMigrationFile } from '../migrations';
 import { flatArray } from '../utils/flatArray';
 
@@ -38,10 +39,14 @@ const downLastAppliedMigration = async (
   if (!migration) {
     throw new Error(`Migration (${lastApplied.className}) not found`);
   }
-
-  await migration.instance.down(connection.db);
-  await deleteMigration(collection, migration);
-  spinner.succeed(`Migration ${lastApplied.className} down`).stop();
+  try {
+    await migration.instance.down(connection.db);
+    await deleteMigration(collection, migration);
+    spinner.succeed(`Migration ${lastApplied.className} down`).stop();
+  } catch (e) {
+    spinner.fail(`Error down migration ${lastApplied.className}`);
+    throw new ExecuteMigrationError(e);
+  }
 };
 
 const downAll = async (
@@ -73,9 +78,14 @@ const downAll = async (
     const localSpinner = ora(
       `Undoing migration ${migration.className}`
     ).start();
-    await migration.instance.down(connection.db);
-    await deleteMigration(collection, migration);
-    localSpinner.succeed(`Migration ${migration.className} down`).stop();
+    try {
+      await migration.instance.down(connection.db);
+      await deleteMigration(collection, migration);
+      localSpinner.succeed(`Migration ${migration.className} down`).stop();
+    } catch (e) {
+      localSpinner.fail(`Error down migration ${migration.className}`);
+      throw new ExecuteMigrationError(e);
+    }
   }
 
   spinner.succeed('All migrations down').stop();