-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync llama.cpp #79
Conversation
I’m almost done, just running the final tests. @Vali-98 , if you have a moment, a quick review would be much appreciated to catch anything I might have missed! |
It looks okay from a glance, can't confirm for the IOS code though. Just to confirm, I applied changes for cui-llama.rn from my fork of llama.cpp: https://github.com/Vali-98/llama.cpp/tree/cui-llama.rn. @a-ghorbani , did you swap to this fork or translated my changes to the relevant patch files? The current method of patching changes to llama.rn is the main reason why I wanted my own fork instead, as patching the files tends to fail spectacularly when syncing llama.cpp. After 2-3 sync's, I decided that it was a major maintainability issue. I assume this is the reason why the CI is failing too. Ideally for release builds, we would include prebuilt binaries instead of needing to redundantly build rn-llama.cpp. |
Cool! For the iOS part, I took some ideas from Android-related changes.
I translated the changes into relevant patch files to maintain consistency with the approach in this repo.
Yep, maintaining these patches is a challenge. usually, I revert the changes and create the patches from scratch again. |
You might want to mention that this adds the |
This is awesome, thanks for the contribution! It looks like |
Sync
llama.cpp
with the b3972 release.This will close #77.