This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
Removing setters from Store #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating, updating and deleting settings should instead be handled by the repository. This simplifies the store greatly. The database store can be updated in the future to use the repository too, but for now I'm keeping it simple. Signed-off-by: Euan Torano <[email protected]>
Signed-off-by: Euan Torano <[email protected]>
Signed-off-by: Euan Torano <[email protected]>
Signed-off-by: Euan Torano <[email protected]>
| */ | ||
| public function update(array $name, $userId = SettingRepositoryInterface::USER_NONE, $package = 'mybb/core') | ||
| { | ||
| $user = $userId = (int)$userId; |
There was a problem hiding this comment.
Is it really necessary to have $user and $userId here? Could be simply $userId which is set to null in the if below.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating, updating and deleting settings should instead be handled by the repository. This simplifies the store greatly.
The database store can be updated in the future to use the repository too, but for now I'm keeping it simple.
Signed-off-by: Euan Torano [email protected]