Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateOnlyTypeHandler should return java.util.Date #3334

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

JoshKloster
Copy link
Contributor

#3332

Fixing the change in return type of DateOnlyTypeHandler introduced here

Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @JoshKloster !

There is just one little request from me. 🙏

@coveralls
Copy link

Coverage Status

coverage: 87.183%. remained the same
when pulling 6a1d9b8 on JoshKloster:fixDateOnlyTypeHandlerReturnType
into f7e6d98 on mybatis:master.

@harawata harawata changed the title Change java.sql.Date to java.util.date DateOnlyTypeHandler should return java.util.Date Dec 27, 2024
@harawata harawata merged commit 64a2736 into mybatis:master Dec 27, 2024
19 checks passed
@hazendaz
Copy link
Member

wow, thanks @JoshKloster. Looking at that again, I totally missed that flip of processing.

@harawata
Copy link
Member

This repo has > 1k watchers and we all missed that.
Even the test case missed it. 🥲
I will update the test if I do not forget, but PR is welcome. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants