Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuel economy units #463

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

emonty
Copy link

@emonty emonty commented Sep 7, 2024

dervied-data can produce fuel-economy paths that show up as m/m^3. Most of us don't think in meters per cubic-meter, even if we love the metric system a whole lot. Add a set of reasonable units for displaying fuel economy. Showing this along-side fuel flow rate can be helpful.

godind

This comment was marked as duplicate.

Copy link
Collaborator

@godind godind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos to fix. Thank for the contribution!

src/app/core/services/units.service.ts Outdated Show resolved Hide resolved
dervied-data can produce fuel-economy paths that show up as m/m^3.
Most of us don't think in meters per cubic-meter, even if we love
the metric system a whole lot. Add a set of reasonable units for
displaying fuel economy. Showing this along-side fuel flow rate
can be helpful.
@emonty emonty force-pushed the fuel-economy-units branch from ca26009 to 92e588a Compare September 8, 2024 03:21
In measuring how much energy we consume to travel a distance, the
units are different if we're travelling via electric propsulsion.

Change the category names to be about distance
@emonty emonty requested a review from godind September 25, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants