Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv runs on mxmmake #25

Merged
merged 7 commits into from
Feb 27, 2024
Merged

uv runs on mxmmake #25

merged 7 commits into from
Feb 27, 2024

Conversation

jensens
Copy link
Member

@jensens jensens commented Feb 26, 2024 •
edited
Loading

  • use uv pip via PYTHON_PACKAGE_INSTALLER?=uv
  • use uv venv via PYTHON_UV_GLOBAL?=true
  • fix tests

@jensens jensens marked this pull request as ready for review February 27, 2024 09:29
@jensens jensens requested a review from rnixx February 27, 2024 09:29
@jensens jensens mentioned this pull request Feb 27, 2024
Open
22 tasks
@jensens
Copy link
Member Author

jensens commented Feb 27, 2024

ready

thet
thet reviewed Feb 27, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
thet
thet reviewed Feb 27, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
thet
thet approved these changes Feb 27, 2024
View reviewed changes
Copy link

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rnixx
rnixx reviewed Feb 27, 2024
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@jensens jensens merged commit dcf3d35 into main Feb 27, 2024
13 checks passed
@jensens jensens deleted the uv branch February 27, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnixx rnixx rnixx left review comments

@thet thet thet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jensens @thet @rnixx