Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #407]🧑‍💻Optimize ConfigManager code #408

Merged
merged 1 commit into from
May 31, 2024
Merged

[ISSUE #407]🧑‍💻Optimize ConfigManager code #408

merged 1 commit into from
May 31, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented May 31, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #407

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 19.10%. Comparing base (df27f4e) to head (4d5fb17).

Files Patch % Lines
rocketmq-common/src/common/config_manager.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   19.10%   19.10%   -0.01%     
==========================================
  Files         207      207              
  Lines       13827    13828       +1     
==========================================
  Hits         2642     2642              
- Misses      11185    11186       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit ff0c3c0 into main May 31, 2024
7 of 9 checks passed
@mxsm mxsm deleted the en-407 branch May 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize ConfigManager code
2 participants