Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #244]🚧Implement TopicConfigManager load method #245

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Mar 7, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #244

Brief Description

How Did You Test This Change?

Copy link
Contributor

@antcarryele antcarryele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 71.35417% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 18.77%. Comparing base (54f837a) to head (3dd0b06).

Files Patch % Lines
...q-remoting/src/protocol/body/topic_info_wrapper.rs 0.00% 16 Missing ⚠️
rocketmq-remoting/src/protocol.rs 0.00% 11 Missing ⚠️
...q-broker/src/topic/manager/topic_config_manager.rs 0.00% 10 Missing ⚠️
rocketmq-common/src/common/config_manager.rs 0.00% 3 Missing ⚠️
rocketmq-broker/src/broker_config.rs 0.00% 2 Missing ⚠️
...oker/src/filter/manager/consumer_filter_manager.rs 0.00% 2 Missing ⚠️
...oker/src/offset/manager/consumer_offset_manager.rs 0.00% 2 Missing ⚠️
.../src/offset/manager/consumer_order_info_manager.rs 0.00% 2 Missing ⚠️
...mq-broker/src/schedule/schedule_message_service.rs 0.00% 2 Missing ⚠️
...subscription/manager/subscription_group_manager.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   17.48%   18.77%   +1.28%     
==========================================
  Files         150      151       +1     
  Lines        7813     8007     +194     
==========================================
+ Hits         1366     1503     +137     
- Misses       6447     6504      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 43bcd92 into main Mar 7, 2024
9 checks passed
@mxsm mxsm deleted the feature-244 branch March 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement TopicConfigManager load method
4 participants