Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #195]🚀Refactor remoting net #196

Merged
merged 2 commits into from
Feb 14, 2024
Merged

[ISSUE #195]🚀Refactor remoting net #196

merged 2 commits into from
Feb 14, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Feb 14, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #195

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (4469971) 10.21% compared to head (e489848) 10.05%.

❗ Current head e489848 differs from pull request most recent head 3b80659. Consider uploading reports for the commit 3b80659 to get more accurate results

Files Patch % Lines
rocketmq-remoting/src/runtime.rs 0.00% 28 Missing ⚠️
rocketmq-broker/src/broker_controller.rs 0.00% 25 Missing ⚠️
rocketmq-namesrv/src/bin/bootstrap_server.rs 0.00% 17 Missing ⚠️
rocketmq-remoting/src/protocol/remoting_command.rs 0.00% 15 Missing ⚠️
rocketmq-remoting/src/runtime/server.rs 0.00% 14 Missing ⚠️
rocketmq-remoting/src/server/config.rs 0.00% 7 Missing ⚠️
rocketmq-common/src/common.rs 0.00% 3 Missing ⚠️
rocketmq-common/src/thread_pool.rs 0.00% 3 Missing ⚠️
rocketmq-broker/src/bin/broker_bootstrap_server.rs 0.00% 2 Missing ⚠️
...namesrv/src/processor/default_request_processor.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   10.21%   10.05%   -0.16%     
==========================================
  Files         123      123              
  Lines        5739     5828      +89     
==========================================
  Hits          586      586              
- Misses       5153     5242      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 7c4f422 into main Feb 14, 2024
7 checks passed
@mxsm mxsm deleted the refactor-net branch February 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Refactor remoting net
2 participants