Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #191]🚀Implementing network communication for the Broker-3 #192

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Feb 12, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #191

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 79 lines in your changes are missing coverage. Please review.

Comparison is base (c3bbaa7) 10.30% compared to head (150377b) 10.21%.

Files Patch % Lines
rocketmq-broker/src/broker_config.rs 0.00% 27 Missing ⚠️
rocketmq-remoting/src/server/rocketmq_server.rs 0.00% 26 Missing ⚠️
rocketmq-broker/src/broker_controller.rs 0.00% 18 Missing ⚠️
...cketmq-store/src/message_store/local_file_store.rs 0.00% 3 Missing ⚠️
rocketmq-broker/src/controller/replicas_manager.rs 0.00% 2 Missing ⚠️
rocketmq-common/src/common/broker/broker_config.rs 0.00% 1 Missing ⚠️
rocketmq-remoting/src/server/config.rs 0.00% 1 Missing ⚠️
rocketmq-store/src/timer/timer_message_store.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   10.30%   10.21%   -0.10%     
==========================================
  Files         119      123       +4     
  Lines        5688     5739      +51     
==========================================
  Hits          586      586              
- Misses       5102     5153      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 93ecdf4 into main Feb 12, 2024
7 of 9 checks passed
@mxsm mxsm deleted the feature-191 branch February 12, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implementing network communication for the Broker-3
2 participants