[ISSUE #1134]🔥Remove BrokerConfig duplicate codes🔥

[rust-learn-now]

Which Issue(s) This PR Fixes(Closes)

Fixes #1134

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Bug Fixes
  • Removed the property indicating whether the broker is within a container from the broker configuration, streamlining the configuration representation.

[coderabbitai]

Walkthrough

The pull request modifies the get_properties method of the BrokerConfig struct in the broker_config.rs file. It specifically removes the insertion of the property "isInBrokerContainer" from the properties HashMap, which affects how broker configuration properties are represented. The method continues to function normally, populating other attributes in the HashMap without additional changes to other logic or structures.

Changes

File Path	Change Summary
rocketmq-common/src/common/broker/broker_config.rs	Removed insertion of "isInBrokerContainer" from get_properties method.

Assessment against linked issues

Objective	Addressed	Explanation
Remove duplicate codes in BrokerConfig (#1134)	✅

Possibly related PRs

• [ISSUE #733]🚀Optimize pull message🔥 #734: This PR modifies the BrokerIdentity struct in the same file (broker_config.rs), indicating potential related changes in the broker configuration context.

Suggested labels

approved, auto merge

Poem

🐇 In the code where brokers play,
A property has hopped away.
No more "isInBrokerContainer" to see,
Just cleaner config, oh so free!
With each tweak, our code will thrive,
In the rabbit hole, we come alive! 🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 15bd965 and c53922a.

📒 Files selected for processing (1)

• rocketmq-common/src/common/broker/broker_config.rs (0 hunks)

💤 Files with no reviewable changes (1)

• rocketmq-common/src/common/broker/broker_config.rs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mxsm]

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥