Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Twitch channels #438

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

b-abadie
Copy link
Contributor

Please keep in mind that I am not a Golang expert. This is my second PR in Go, and the first one was a minor bugfix.

I have had the branch running for a few months now, it's doing fine.

@b-abadie
Copy link
Contributor Author

Oh, I forgot that I never adapted the README, please do not merge right now. I especially need to document the token format and generation. FYI its generated here https://dev.twitch.tv/console/apps and the format in [tokens] is twitch = "client_id:client_secret" if I recall correctly.

If someone wants to do it, be my guest. I'll try to add a commit in the next few days otherwise.

@mxpv
Copy link
Owner

mxpv commented Oct 25, 2022

Thanks for contributing this!
Just a few comments:

  • Linter has a few minor complains.
  • Some basic unit tests would be nice to have to make sure this works as expected.
  • README updates.

@Garfonso
Copy link

It would be real nice, if this could be merged at some point in time. I really like the feature. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants